adding/increasing default number of lines for mr description rendering #45

simon · 2026-01-19T14:53:36+01:00

simon commented

2026-01-19 14:53:36 +01:00

I thought instead of making an issue I'd try to solve it "my self".

simon added 1 commit

2026-01-19 14:53:37 +01:00

adding/increasing default number of lines for mr description rendering 5200b5e610

simon requested review from smgt

2026-01-19 14:53:58 +01:00

smgt reviewed

2026-01-19 15:00:33 +01:00

internal/input/text.go Outdated

					
				@ -19,2 +25,3 @@

						CharLimit(1000000).

						Value(&i.Text)

						Value(&i.Text).

						Lines(i.lines)

In go when you initialize a int it defaults to zero. So if the text input were to be used anywhere else with input.NewText("asdf") it would be zero lines long. I would recommend to instead check if i.lines is zero and if it is we don't pass Lines(i.lines) to huh.NewText.

t := huh.NewText().
Title(i.title).
CharLimit(10000000)

if i.linues != 0 {
  t = t.Lines(i.lines)
}

return t.Value(&i.Text)

In go when you initialize a int it defaults to zero. So if the text input were to be used anywhere else with `input.NewText("asdf")` it would be zero lines long. I would recommend to instead check if `i.lines` is zero and if it is we don't pass `Lines(i.lines)` to `huh.NewText`. ```go t := huh.NewText(). Title(i.title). CharLimit(10000000) if i.linues != 0 { t = t.Lines(i.lines) } return t.Value(&i.Text) ```